Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[problemchild] Ensure event.kind is correctly set for pipeline errors #7501

Merged
merged 4 commits into from
Aug 29, 2023
Merged

[problemchild] Ensure event.kind is correctly set for pipeline errors #7501

merged 4 commits into from
Aug 29, 2023

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Aug 22, 2023 •
edited
Loading

What does this PR do?

Modify problemchild integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish marked this pull request as ready for review August 22, 2023 22:36
@MakoWish MakoWish requested review from a team as code owners August 22, 2023 22:36
@elasticmachine
Copy link

elasticmachine commented Aug 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-24T19:08:06.252+0000

  • Duration: 16 min 30 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

peteharverson
peteharverson approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM - ml-ui are down as CODEOWNERS of this package. No specific ML changes here but LGTM to clear the ml-ui approval.

@MakoWish
Copy link
Contributor Author

Would someone mind kicking off a /test? I don't have permissions.

@susan-shu-c
Copy link
Member

/test

@MakoWish
Copy link
Contributor Author

I don't have permissions to merge. Would someone be so kind? :-)

@susan-shu-c susan-shu-c merged commit 1c48a89 into elastic:main Aug 29, 2023
4 checks passed
@susan-shu-c
Copy link
Member

Just saw this, merged!

@elasticmachine
Copy link

Package problemchild - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=problemchild

@MakoWish MakoWish deleted the 6582-problemchild branch August 29, 2023 17:41
gizas pushed a commit that referenced this pull request Sep 5, 2023
@MakoWish @gizas
[problemchild] Ensure event.kind is correctly set for pipeline errors (…
e1b3e6e 
…#7501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@susan-shu-c susan-shu-c susan-shu-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MakoWish @elasticmachine @susan-shu-c @peteharverson