Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure][database_account] Add dimension and metric_type metadata #7503

Merged
merged 5 commits into from Sep 11, 2023
Merged

[Azure][database_account] Add dimension and metric_type metadata #7503

merged 5 commits into from Sep 11, 2023

Conversation

tetianakravchenko
Copy link
Contributor

What does this PR do?

Add dimension and metric_type metadata to support TSDB.

Note: this PR is pending on #7502, where was added few more azure dimentions

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tetianakravchenko
Add dimension and metric_type metadata to the database_account datast…
996a807 
…ream

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner August 23, 2023 09:18
@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-11T13:05:15.469+0000

  • Duration: 13 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 75.758% (25/33) 👎 -20.119
Lines 100.0% (32/32) 💚 11.799
Conditionals 100.0% (0/0) 💚

@tetianakravchenko
add azure.dimension fields region and command_name; fix merge conflicts
43e2073 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
Copy link
Contributor Author

tetianakravchenko commented Aug 29, 2023 •
edited

@zmoog @gpop63 After merging in this PR - #7502, where were added Region and CommandName dimensions - I've updated the list of azure.dimensions - 43e2073
Please have a look

zmoog
zmoog reviewed Aug 30, 2023
View reviewed changes
packages/azure_metrics/data_stream/database_account/fields/agent.yml
@@ -48,6 +48,7 @@
ignore_above: 1024
description: Region in which this host is running.
example: us-east-1
dimension: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the region the agent is running into, or the database account region?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmoog It is a database account region.
Actually it could be that azure.dimensions.region is redundant:
Screenshot 2023-09-01 at 17 48 24

Initially I've noticed that it is possible to configure global distribution and assumed that region should be added:
Screenshot 2023-09-01 at 17 46 36

do you think that the region dimension should be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: region azure dimension was removed - 25520d8 (related PR)

zmoog
zmoog approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I added one clarification question only.

@tetianakravchenko tetianakravchenko mentioned this pull request Sep 8, 2023
Merged
4 tasks
@tetianakravchenko
remove region from the list of fields; fix merge conflict
25520d8 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
run elastic-package build; remove region dimension from the documenta…
4121421 
…tion

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko merged commit 948dafa into elastic:main Sep 11, 2023
4 checks passed
@tetianakravchenko tetianakravchenko deleted the azure_database_account_tsdb branch September 11, 2023 13:20
@elasticmachine
Copy link

Package azure_metrics - 1.0.40 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@gpop63 gpop63 gpop63 approved these changes

@agithomas agithomas Awaiting requested review from agithomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tetianakravchenko @elasticmachine @zmoog @gpop63