Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Oracle WebLogic] Add metric_type for deployed_application datastream #7513

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Aug 23, 2023

  • Enhancement

What does this PR do?

This PR adds metric type mapping for the fields of deployed_application datastream.

Checklist

#7512

@harnish-elastic harnish-elastic added enhancement New feature or request Integration:oracle_weblogic Oracle WebLogic labels Aug 23, 2023
@harnish-elastic harnish-elastic self-assigned this Aug 23, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review August 23, 2023 16:16
@harnish-elastic harnish-elastic requested a review from a team as a code owner August 23, 2023 16:16
@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-12T10:07:38.247+0000

  • Duration: 26 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 49
Skipped 0
Total 49

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.35
Classes 100.0% (4/4) 💚 3.35
Methods 100.0% (44/44) 💚 8.137
Lines 100.0% (239/239) 💚 11.681
Conditionals 100.0% (0/0) 💚

@devamanv
Copy link
Contributor

devamanv commented Aug 29, 2023

@harnish-elastic Can we just check to see if we can add the unit wherever applicable?
One small suggestion, the template for creating a PR description says add the appropriate label. It seems a little redundant and a little incomplete to see a word like Bug/Enhancement right at the top when adding a label instead should be enough. It would be better if that is somehow specified in the What does this PR do? section itself.

@harnish-elastic
Copy link
Contributor Author

harnish-elastic commented Aug 31, 2023

@harnish-elastic Can we just check to see if we can add the unit wherever applicable? One small suggestion, the template for creating a PR description says add the appropriate label. It seems a little redundant and a little incomplete to see a word like Bug/Enhancement right at the top when adding a label instead should be enough. It would be better if that is somehow specified in the What does this PR do? section itself.

@devamanv This PR is related to TSDB enablement and I need to research more for adding the unit. Also, the add unit is not related to TSDB enablement. So I have created a separate issue for it, as part of it I’ll add a unit!

@harnish-elastic harnish-elastic removed the enhancement New feature or request label Aug 31, 2023
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…into oracle_weblogic-deployed_application-add-metric_type

Conflicts:
	packages/oracle_weblogic/changelog.yml
	packages/oracle_weblogic/docs/README.md
@harnish-elastic harnish-elastic merged commit aeed9aa into elastic:main Oct 12, 2023
4 checks passed
@elasticmachine
Copy link

Package oracle_weblogic - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=oracle_weblogic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants