Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Oracle WebLogic] Add metric_type for threadpool datastream #7514

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Aug 23, 2023

  • Enhancement

What does this PR do?

This PR adds metric type mapping for the fields of threadpool datastream.

Checklist

Screenshot

Refer: #7512

@harnish-elastic harnish-elastic marked this pull request as ready for review August 23, 2023 16:29
@harnish-elastic harnish-elastic requested a review from a team as a code owner August 23, 2023 16:29
@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-12T11:57:11.797+0000

  • Duration: 26 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 49
Skipped 0
Total 49

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.35
Classes 100.0% (4/4) 💚 3.35
Methods 100.0% (44/44) 💚 8.137
Lines 100.0% (239/239) 💚 11.681
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (44/44) 💚
Lines 100.0% (239/239) 💚
Conditionals 100.0% (0/0) 💚

@botelastic
Copy link

botelastic bot commented Sep 23, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@agithomas
Copy link
Contributor

@harnish-elastic , please complete the peer review as well.

@agithomas
Copy link
Contributor

@lalit-satapathy , are you good to approve the PR from your end?

@agithomas
Copy link
Contributor

@harnish-elastic , i examined the information available here to determine if the fields are of type gauge or counter. But, i couldnt find any relevant information.

Do you have any source that is used to annotate the various metric_type added as part of this PR?

@harnish-elastic
Copy link
Contributor Author

@harnish-elastic , i examined the information available here to determine if the fields are of type gauge or counter. But, i couldnt find any relevant information.

Do you have any source that is used to annotate the various metric_type added as part of this PR?

I have also tried to find documents useful for adding metric_type as part of this PR, however, I couldn't find any docs. I have also referred to the doc that you have provided and based on the description and data collection, I have added metric_type fields.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…into oracle_weblogic-threadpool-add-metric_type

Conflicts:
	packages/oracle_weblogic/changelog.yml
	packages/oracle_weblogic/docs/README.md
	packages/oracle_weblogic/manifest.yml
@harnish-elastic harnish-elastic merged commit ea5ec9b into elastic:main Oct 12, 2023
4 checks passed
@elasticmachine
Copy link

Package oracle_weblogic - 1.1.3 containing this change is available at https://epr.elastic.co/search?package=oracle_weblogic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants