[O11y][Oracle WebLogic] Add dimension fields for threadpool datastream #7517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harnish-elastic
added
enhancement
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
11 tasks
🌐 Coverage report
|
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
agithomas
reviewed
Sep 26, 2023
packages/oracle_weblogic/data_stream/threadpool/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
agithomas
approved these changes
Sep 27, 2023
…into oracle_weblogic-threadpool-add-dimension Conflicts: packages/oracle_weblogic/changelog.yml packages/oracle_weblogic/manifest.yml
|
Package oracle_weblogic - 1.1.2 containing this change is available at https://epr.elastic.co/search?package=oracle_weblogic |
|
Marked done in the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds dimension fields for threadpool datastream to support TSDB enablement.
Issue: In the ThreadPool datastream, the data collection is performed by Jolokia input and there are different MBeans used to perform data collection. Because of different MBeans, multiple events are generated at the same time. And I don't have found any possible unique identifier field in fields.yml file for threadpool datastream. Hence the data was getting dropped while performing the data collection because of getting multiple events at the same time.
Possible Solution: To overcome the above issue, I have introduced a unique identifier called
oracle_weblogic.threadpool.mbeanthat represents the value of the doc that is collected from the particular MBean and makes it dimension true.Checklist
I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's
changelog.ymlfile.I have verified that Kibana version constraints are current according to guidelines.
Relates Oracle WebLogic TSDB Enablement #7512
Screenshot
Refer: #7512