Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][GoLang] Add metric_type for expvar data stream #7528

Merged

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Aug 24, 2023

  • Enhancement

What does this PR do?

  • Add missing metric_type for expvar data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@harnish-elastic harnish-elastic self-assigned this Aug 24, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review August 24, 2023 09:28
@harnish-elastic harnish-elastic requested a review from a team as a code owner August 24, 2023 09:28
@elasticmachine
Copy link

elasticmachine commented Aug 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-31T05:01:05.393+0000

  • Duration: 15 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 24, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.362
Classes 100.0% (2/2) 💚 3.362
Methods 100.0% (16/16) 💚 8.17
Lines 95.833% (184/192) 👍 7.524
Conditionals 100.0% (0/0) 💚

@devamanv
Copy link
Contributor

devamanv commented Aug 29, 2023

Changes look good, just one comment: have we considered treating changes like these to be patch version increments, instead of minor version change i.e. 0.4.1 instead of 0.5.0?

…into golang-add-metric_type

Conflicts:
	packages/golang/changelog.yml
	packages/golang/manifest.yml
@harnish-elastic
Copy link
Contributor Author

Changes look good, just one comment: have we considered treating changes like these to be patch version increments, instead of minor version change i.e. 0.4.1 instead of 0.5.0?

Updated, thanks!

Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harnish-elastic harnish-elastic merged commit 113312b into elastic:main Sep 4, 2023
4 checks passed
@elasticmachine
Copy link

Package golang - 0.4.2 containing this change is available at https://epr.elastic.co/search?package=golang

gizas pushed a commit that referenced this pull request Sep 5, 2023
Add missing metric_type for expvar data stream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][Golang] Missing metric_type in fields.yml file
4 participants