Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Couchbase] Added dimensions mapping to database_stats datastream #7540

Merged
merged 2 commits into from Sep 6, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Aug 25, 2023

  • Enhancement

What does this PR do?

Add dimensions to database_stats datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  1. Build verification
    elastic-package build
    elastic-package stack up -v -d --services package-registry
  • 2. Document count verification after enablement

  • 3. Dashboard verification after enablement

  • 4. Index template verification

  • 5. Index mapping verification

  • 6. Index settings verification.

  • Verified that there exists mapping time_series_dimensions mapping after tsdb enablement

  • Verified that there exists time_series settings after TSDB enablement.

  • Verified that the dashboards are not broken after the TSDB enablement.

  • Index rollover after TSDB disablement

Related issues

@agithomas agithomas changed the title Added dimensions mapping to database_stats datastream [Couchbase] Added dimensions mapping to database_stats datastream Aug 25, 2023
@agithomas
Copy link
Contributor Author

Dashboard panel validation

image

@elasticmachine
Copy link

elasticmachine commented Aug 25, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-25T11:27:11.376+0000

  • Duration: 25 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 100.0% (10/10) 💚 12.5
Classes 100.0% (10/10) 💚 12.5
Methods 100.0% (72/72) 💚 18.483
Lines 100.0% (1076/1076) 💚 14.475
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor Author

Rollover testing

{
  "acknowledged": true,
  "shards_acknowledged": true,
  "old_index": ".ds-metrics-couchbase.database_stats-default-2023.08.25-000002",
  "new_index": ".ds-metrics-couchbase.database_stats-default-2023.08.25-000003",
  "rolled_over": true,
  "dry_run": false,
  "conditions": {}
}

@agithomas agithomas marked this pull request as ready for review August 25, 2023 11:39
@agithomas agithomas requested a review from a team as a code owner August 25, 2023 11:39
@agithomas agithomas mentioned this pull request Aug 28, 2023
74 tasks
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 7c1e04d into elastic:main Sep 6, 2023
4 checks passed
@elasticmachine
Copy link

Package couchbase - 1.2.4 containing this change is available at https://epr.elastic.co/search?package=couchbase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants