Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] [API Gateway] Enhance logs dashboard with filtering #7541

Merged

Conversation

lucian-ioan
Copy link
Contributor

@lucian-ioan lucian-ioan commented Aug 25, 2023

Urgency

  • Normal

Activity Type

  • Enhancement

What does this PR do?

Enhances current API Gateway Logs Dashboard with filters based on API ID, Domain Name, and Stage (added in #7151) and AWS Region.

Unfortunately, there is no way to filter based on API type (HTTP, REST, or Websocket) because no such identifier is present in the logs available from AWS.

Since this integration is fairly new (above 8.8), manual editing of the JSON is required without the possibility of exporting the dashboard.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Switch pie charts to tree maps for better visibility
  • Randomize API indentifiers

How to test this PR locally

Related issues

Screenshots

Before:

before

After:

filebeat-aws-apigateway-overview

@lucian-ioan lucian-ioan added enhancement New feature or request Integration:AWS labels Aug 25, 2023
@lucian-ioan lucian-ioan self-assigned this Aug 25, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 25, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-03T17:40:19.975+0000

  • Duration: 53 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 208
Skipped 4
Total 212

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 25, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -2.197
Classes 94.444% (17/18) 👎 -2.197
Methods 85.953% (257/299) 👎 -6.35
Lines 86.024% (7509/8729) 👎 -2.247
Conditionals 100.0% (0/0) 💚

@lucian-ioan lucian-ioan marked this pull request as ready for review September 3, 2023 17:41
@lucian-ioan lucian-ioan requested review from a team as code owners September 3, 2023 17:41
@lucian-ioan lucian-ioan merged commit 3a8539e into elastic:main Sep 4, 2023
4 checks passed
@elasticmachine
Copy link

Package aws - 2.1.1 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] [API Gateway] Enhance logs dashboard with filtering
3 participants