Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] [Container Service] Normalize azure.dimensions.status metric values to lowercase #7551

Merged

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Aug 27, 2023

What does this PR do?

Since values from Azure come in lowercase and capitalized versions (e.g., True/true/False/false), we picked lowercase as canonical case for these values.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Before:

CleanShot 2023-08-27 at 23 55 47@2x

After normalization:

CleanShot 2023-08-27 at 23 58 06@2x

@zmoog zmoog self-assigned this Aug 27, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-31T06:02:45.107+0000

  • Duration: 15 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 27, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.362
Classes 100.0% (4/4) 💚 3.362
Methods 75.758% (25/33) 👎 -16.072
Lines 100.0% (32/32) 💚 11.691
Conditionals 100.0% (0/0) 💚

@zmoog zmoog force-pushed the zmoog/azure-container-service-normalize-status branch from 85dbf21 to 88cf08d Compare August 27, 2023 21:52
@zmoog zmoog marked this pull request as ready for review August 27, 2023 22:02
@zmoog zmoog requested a review from a team as a code owner August 27, 2023 22:02
@zmoog zmoog force-pushed the zmoog/azure-container-service-normalize-status branch 2 times, most recently from d5536d1 to 3296c3c Compare August 29, 2023 15:31
Since values from Azure come in lowercase and capitalized versions
(e.g., True/true/False/false), we picked lowercase as canonical case
for these values.
@zmoog zmoog force-pushed the zmoog/azure-container-service-normalize-status branch from 3296c3c to bdbe649 Compare August 31, 2023 06:02
@zmoog zmoog merged commit e32c023 into elastic:main Aug 31, 2023
4 checks passed
@zmoog zmoog deleted the zmoog/azure-container-service-normalize-status branch August 31, 2023 06:28
@elasticmachine
Copy link

Package azure_metrics - 1.0.35 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

gizas pushed a commit that referenced this pull request Sep 5, 2023
…values to lowercase (#7551)

* Normalize azure.dimensions.status values to lowercase

Since values from Azure come in lowercase and capitalized versions
(e.g., True/true/False/false), we picked lowercase as canonical case
for these values.

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Azure] [container_service] Handle boolean values
4 participants