Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP][CloudSQL] Set metric type #7556

Merged
merged 2 commits into from Aug 29, 2023
Merged

[GCP][CloudSQL] Set metric type #7556

merged 2 commits into from Aug 29, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Metric type of GCP CloudSQL metrics can be found here.

Set the metric type for:

  • CloudSQL - MySQL
  • CloudSQL - PostgreSQL
  • CloudSQL - SQL Server

Changes:

  1. Switch every delta metric marked as counter to gauge.
  2. Add metric type to the metrics without type.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #7555.

@constanca-m
Set metric type.
84695d6 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m requested review from a team as code owners August 28, 2023 08:20
@constanca-m
Update changelog.
0fdcd8e 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m mentioned this pull request Aug 28, 2023
Open
4 tasks
@constanca-m constanca-m self-assigned this Aug 28, 2023
@constanca-m constanca-m added Integration:GCP Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 28, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 28, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-28T08:21:59.055+0000

  • Duration: 19 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 68
Skipped 0
Total 68

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 87.826% (101/115) 👍 14.493
Lines 96.0% (1464/1525) 👎 -4.0
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m merged commit 69bfb75 into elastic:main Aug 29, 2023
4 checks passed
@constanca-m constanca-m deleted the gcp-add-metric-type branch August 29, 2023 06:00
@elasticmachine
Copy link

Package gcp - 2.28.1 containing this change is available at https://epr.elastic.co/search?package=gcp

gizas pushed a commit that referenced this pull request Sep 5, 2023
@constanca-m @gizas
[GCP][CloudSQL] Set metric type (#7556)
fdc2aa5 
* Set metric type.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

* Update changelog.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

---------

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

Assignees

@constanca-m constanca-m

Labels
Integration:GCP Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@constanca-m @elasticmachine @zmoog