Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ti_misp] - update package-spec to 2.10.0 #7570

Merged
merged 2 commits into from Aug 29, 2023
Merged

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Aug 28, 2023

What does this PR do?

  • Update package-spec to 2.10.0
  • Ensure event.category is an array
  • Ensure event.type is an array
[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.9.0 -ecs-git-ref=v8.9.0 -format-version=2.10.0 packages/ti_misp

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

  • Relates elastic/security-team#5870

- Update package-spec to 2.10.0
- Ensure event.category is an array
- Ensure event.type is an array

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.9.0 -ecs-git-ref=v8.9.0 -format-version=2.10.0 -pr=1 packages/ti_misp
@elasticmachine
Copy link

elasticmachine commented Aug 28, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-28T16:08:14.144+0000

  • Duration: 17 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (30/30) 💚 25.0
Lines 86.831% (633/729) 👎 -13.169
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review August 28, 2023 16:44
@taylor-swanson taylor-swanson requested a review from a team as a code owner August 28, 2023 16:44
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

"Attribute": []
}
}
body: "{\n \"response\": {\n \"Attribute\": []\n }\n} "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a result of the automation? It's unfortunate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that was elastic-package doing some formatting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally it should leave this kind of thing alone, this is harder to read now.

@taylor-swanson taylor-swanson merged commit 4247941 into main Aug 29, 2023
4 checks passed
@taylor-swanson taylor-swanson deleted the pkg-spec-ti_misp branch August 29, 2023 13:00
@elasticmachine
Copy link

Package ti_misp - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=ti_misp

gizas pushed a commit that referenced this pull request Sep 5, 2023
- Update package-spec to 2.10.0
- Ensure event.category is an array
- Ensure event.type is an array

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.9.0 -ecs-git-ref=v8.9.0 -format-version=2.10.0 packages/ti_misp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:MISP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants