Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_asa: add support for unspecified reason AAA user authentication rejection #7604

Merged
merged 1 commit into from Aug 30, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 29, 2023

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Aug 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-30T00:30:29.396+0000

  • Duration: 17 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 94.444% (17/18)
Lines 69.824% (1548/2217)
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review August 29, 2023 23:17
@efd6 efd6 requested a review from a team as a code owner August 29, 2023 23:17
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 changed the title cisco_asa: add support for unspecified reason AAA user authenticaton rejection cisco_asa: add support for unspecified reason AAA user authentication rejection Aug 30, 2023
Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 74eef6c into elastic:main Aug 30, 2023
4 checks passed
@elasticmachine
Copy link

Package cisco_asa - 2.20.4 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

gizas pushed a commit that referenced this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:CiscoASA Cisco ASA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline fails to dissect Cisco ASA messages with ID 113005
3 participants