Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Logs] Implement input parameter ignore_older #7615

Merged
merged 4 commits into from Sep 14, 2023
Merged

[Custom Logs] Implement input parameter ignore_older #7615

merged 4 commits into from Sep 14, 2023

Conversation

EmiBruno
Copy link
Contributor

@EmiBruno EmiBruno commented Aug 30, 2023

  • Enhancement

What does this PR do?

Expose ignore_older option for the Custom Logs integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  1. Build package and startup test environment:
cd package/log
elastic-package build
elastic-package stack up -v -d --services package-registry
  1. Add a new "Custom Logs" integration to a policy
  2. Verify if the correct logs are collected by the datastream

Related issues

@EmiBruno EmiBruno marked this pull request as ready for review August 30, 2023 16:35
@EmiBruno EmiBruno requested a review from a team as a code owner August 30, 2023 16:35
@elasticmachine
Copy link

elasticmachine commented Aug 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-14T12:52:21.994+0000

  • Duration: 14 min 6 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@rdner
Copy link
Member

rdner commented Sep 14, 2023

/test

packages/log/manifest.yml Show resolved Hide resolved
@EmiBruno EmiBruno requested a review from rdner September 14, 2023 09:29
packages/log/manifest.yml Outdated Show resolved Hide resolved
Co-authored-by: Denis <denis@rdner.de>
@rdner rdner merged commit 8143f22 into elastic:main Sep 14, 2023
3 checks passed
@elasticmachine
Copy link

Package log - 2.2.0 containing this change is available at https://epr.elastic.co/search?package=log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Custom Logs] Implement input parameter ignore_older
3 participants