Migrating traefik module #763
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
ycombinator
force-pushed
the
migrate-traefik
branch
from
0281a16
to
a29bb61
Compare
|
Pinging @elastic/integrations (Team:Integrations) |
| @@ -0,0 +1,23 @@ | |||
| - name: traefik.health | |||
| type: group | |||
| release: ga | |||
There was a problem hiding this comment.
I'm guessing you want me to change it to experimental so it matches up with the release in the package-level manifest.yml?
BTW, this is what was generated by the migration script. Should we update it to generate release: experimental?
There was a problem hiding this comment.
I guess it's because originally integrations were supposed to be 1:1 modules. If a module was released GA, so the integration too. You can open an issue, but I'm not sure about it's priority (rather low, it's easy to adjust after migration).
There was a problem hiding this comment.
I just realized that this release: ga is in the fields.yml, not the manifest.yml. I'm fixing it to be release: experimental but I'm seeing some other packages (e.g. nats, docker) where the release is set to ga in their fields.yml but the package manifest.yml has release: experimental or release: beta.
There was a problem hiding this comment.
Actually, I ended up just removing the release field from this fields.yml file (c857182). I checked the spec for field definition files and that field is not even mentioned in there. So I'm not even sure of it's purpose or if we need it. 🤷
|
|
||
| ## Compatibility | ||
|
|
||
| The Traefik datasets were tested with Traefik 1.6. |
There was a problem hiding this comment.
I suppose that you didn't check compatibility with a more recent version?
There was a problem hiding this comment.
No, not yet. In this PR I'm just focussing on the basic migration. I will make a follow up PR to test with a more recent version and then make the necessary updates to the package.
There was a problem hiding this comment.
Ignore my previous comment. I updated the version of Traefik in this PR to 1.7.
There is a 2.x version series as well but I think we should leave that for a follow up PR as it might contain breaking changes. WDYT?
|
jenkins run the tests please |
ycombinator
force-pushed
the
migrate-traefik
branch
from
44fed59
to
b43c460
Compare
ycombinator
force-pushed
the
migrate-traefik
branch
from
10daba6
to
c2a87a3
Compare
* Migrating traefik module * Formatting package files * Removing invalid path field * Adding categories * Adding changelog file * Formatting tweaks * Adding pipeline test files * Adding YAML header * Adding system tests * Reformatting * Renaming pipeline test case files * Fixing pipeline tests * Adding ECS fields for health data stream * Adding README template file * Adding sample event for health data set * Adding system test for access data stream * Reformatting * Adding README * Removing host field from sample event files * Fixing kibana compatibility version * Testing with version 1.7 * Updating README * Remove release field from fields.yml * Remove temp field * Updating screenshot
What does this PR do?
Migrates the
traefikmodule from Beats to Integrations.Checklist
changelog.ymlfile.Screenshots
Related issues