Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hadoop] Add dimension mapping for cluster datastream. #7631

Merged
merged 5 commits into from Sep 12, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Sep 1, 2023

  • Enhancement

What does this PR do?

Add dimensions to cluster datastream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • 1. Build verification
    elastic-package build
    elastic-package stack up -v -d --services package-registry

  • 2. Document count verification after enablement

  • 3. Dashboard verification after enablement.

  • 4. Index template verification

  • 5. Index mapping verification

  • 6. Index settings verification.

  • 7. Index rollover after TSDB disablement verification

Related issues

Screenshots

@ritalwar ritalwar requested a review from a team as a code owner September 1, 2023 06:57
@ritalwar ritalwar mentioned this pull request Sep 1, 2023
21 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-12T12:13:05.150+0000

  • Duration: 22 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 1, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (47/47) 💚
Lines 99.18% (605/610) 👍 6.892
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit 6ab3b75 into elastic:main Sep 12, 2023
4 checks passed
@elasticmachine
Copy link

Package hadoop - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=hadoop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants