Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[elasticsearch] add api_key authentication #7637

Merged
merged 2 commits into from Sep 8, 2023
Merged

[elasticsearch] add api_key authentication #7637

merged 2 commits into from Sep 8, 2023

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Sep 1, 2023 •
edited

Summary

Closes #7377

Adds support for api_key authentication in elasticsearch integration

Testing

  • create an api key and grab the beats format[1]
  • configure elasticsearch integration to use that api_key instead of username/password
  • elasticsearch data is successfully collecting documents and Stack Monitoring shows up. No authentication failure appears in elastic-agent logs/metrics-* data

[1]
Screenshot 2023-08-09 at 17 23 25

klacabane
klacabane commented Sep 1, 2023
View reviewed changes
packages/elasticsearch/manifest.yml
@@ -12,7 +12,7 @@ format_version: 2.6.0
categories: ["elastic_stack", "datastore"]
conditions:
elastic.subscription: basic
kibana.version: ^8.8.0
kibana.version: ^8.10.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underlying beats support was added in 8.10

@klacabane klacabane self-assigned this Sep 1, 2023
@klacabane klacabane added Integration:Elasticsearch Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Sep 1, 2023
@klacabane klacabane marked this pull request as ready for review September 1, 2023 12:59
@klacabane klacabane requested a review from a team as a code owner September 1, 2023 12:59
@elasticmachine
Copy link

elasticmachine commented Sep 1, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-01T12:52:33.076+0000

  • Duration: 38 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 60
Skipped 0
Total 60

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 87.5% (98/112) 👎 -8.376
Lines 91.98% (562/611) 👍 3.78
Conditionals 100.0% (0/0) 💚

crespocarlos
crespocarlos approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! ⛵

@klacabane klacabane merged commit a790e53 into elastic:main Sep 8, 2023
4 checks passed
@elasticmachine
Copy link

Package elasticsearch - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=elasticsearch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees

@klacabane klacabane

Labels
Integration:Elasticsearch Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[elasticsearch] support api_key
3 participants
@klacabane @elasticmachine @crespocarlos