Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Azure Metrics] Migrate Container Instance Overview dashboard to lens #7638

Conversation

rajvi-patel-22
Copy link
Contributor

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Container Instance Overview visualizations to the lens in the current Kibana version 8.4.0 itself.

  • Statistics for Container Instance Overview Lens migration:

Migration stats

  Before Migration     After Migration    
  Lens Visualization Old Input Controls Lens Visualization New control panels
[Azure Metrics] Container Instance Overview 0 4 1 4 0 1

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team September 1, 2023 13:10
@elasticmachine
Copy link

elasticmachine commented Sep 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-01T13:10:19.451+0000

  • Duration: 15 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 75.758% (25/33) 👎 -20.119
Lines 100.0% (32/32) 💚 11.799
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review September 4, 2023 05:26
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner September 4, 2023 05:26
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajvi-patel-22 rajvi-patel-22 merged commit 2215e79 into elastic:main Sep 6, 2023
4 checks passed
@elasticmachine
Copy link

Package azure_metrics - 1.0.36 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard enhancement New feature or request Integration:azure_metrics Azure Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants