Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netflow,network_traffic,suricata: use dynamic field definitions #7657

Merged
merged 1 commit into from Sep 6, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 5, 2023

What does this PR do?

See title.

This is a counter proposal for #7271, #7273 and #7275.

/cc @MakoWish

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Sep 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-05T03:25:53.224+0000

  • Duration: 67 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 182
Skipped 0
Total 182

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (8/8) 💚
Classes 100.0% (8/8) 💚
Methods 99.099% (110/111) 👍 6.64
Lines 94.81% (1096/1156) 👍 3.308
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review September 5, 2023 04:33
@efd6 efd6 requested a review from a team as a code owner September 5, 2023 04:33
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit 27558a4 into elastic:main Sep 6, 2023
4 checks passed
@elasticmachine
Copy link

Package netflow - 2.13.0 containing this change is available at https://epr.elastic.co/search?package=netflow

@elasticmachine
Copy link

Package network_traffic - 1.22.0 containing this change is available at https://epr.elastic.co/search?package=network_traffic

@elasticmachine
Copy link

Package suricata - 2.13.0 containing this change is available at https://epr.elastic.co/search?package=suricata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants