Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] [API Gateway] Fix aggregation types for metrics dashboard #7675

Merged

Conversation

lucian-ioan
Copy link
Contributor

@lucian-ioan lucian-ioan commented Sep 6, 2023

Urgency

  • High

Activity Type

  • Bugfix

What does this PR do?

Updates aggregation types in the metrics dashboard for AWS API Gateway to match the statistics used in the integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Example for [REST] Count After:
REST_after

@lucian-ioan lucian-ioan requested a review from a team as a code owner September 6, 2023 11:57
@elasticmachine
Copy link

elasticmachine commented Sep 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-06T12:00:14.217+0000

  • Duration: 55 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 208
Skipped 4
Total 212

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -5.556
Classes 94.444% (17/18) 👎 -5.556
Methods 85.953% (257/299) 👎 -13.573
Lines 86.024% (7509/8729) 👎 -11.771
Conditionals 100.0% (0/0) 💚

@lucian-ioan lucian-ioan merged commit 74e55ab into elastic:main Sep 6, 2023
4 checks passed
@elasticmachine
Copy link

Package aws - 2.1.2 containing this change is available at https://epr.elastic.co/search?package=aws

@lucian-ioan lucian-ioan deleted the fix_aws_apigateway_metrics_dashboard branch February 6, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] [API Gateway] Fix aggregation types for metrics dashboard
3 participants