Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Azure Metrics] Migrate File Storage Overview dashboard to lens #7692

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Sep 7, 2023

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Azure File Storage visualizations to the lens in the current Kibana version 8.9.0 itself.

  • Statistics for Azure File Storage Lens migration:

Migration stats

  Before Migration     After Migration    
  Lens Visualization Old Input Controls Lens Visualization New control panels
[Azure Metrics] File Storage Overview 0 11 1 11 0 1

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

Before Migration
image

After Migration
image

@kush-elastic kush-elastic requested review from rajvi-patel-22 and a team September 7, 2023 04:51
@kush-elastic kush-elastic marked this pull request as ready for review September 7, 2023 04:51
@kush-elastic kush-elastic requested a review from a team as a code owner September 7, 2023 04:51
@elasticmachine
Copy link

elasticmachine commented Sep 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-13T06:37:29.699+0000

  • Duration: 15 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 2.695
Classes 100.0% (4/4) 💚 2.695
Methods 75.758% (25/33) 👎 -16.506
Lines 100.0% (32/32) 💚 11.671
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file and share count values have decimals:

CleanShot 2023-09-08 at 12 54 12@2x

Shouldn't these be integer values?

@kush-elastic
Copy link
Collaborator Author

@zmoog ,
Both the visualizations were already using Average aggregation before migration, we will need to create new tickets to address this issue. As part of this PR scope, our focus will be only on migration.

Screenshot 2023-09-08 at 4 46 24 PM Screenshot 2023-09-08 at 4 46 58 PM

@kush-elastic kush-elastic self-assigned this Sep 11, 2023
@kush-elastic
Copy link
Collaborator Author

@zmoog,
As discussed here I think we can unblock this PR as well.

Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed at #7662 (comment), @kush-elastic will open a dedicated issue to address the decimals in the count.

@kush-elastic kush-elastic merged commit 84716ed into elastic:main Sep 13, 2023
4 checks passed
@elasticmachine
Copy link

Package azure_metrics - 1.0.43 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][Azure Metrics] Azure Storage Account Lens migration
4 participants