Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dashboards, fix timestamp and improve fingerprinting #7696

Merged
merged 2 commits into from Sep 8, 2023
Merged

update dashboards, fix timestamp and improve fingerprinting #7696

merged 2 commits into from Sep 8, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 7, 2023 •
edited

What does this PR do?

  • update dashboard branding for the branding change
  • make timestamp reflect last seen rather than first seen
  • reduce event collision by adding fingerprint processor

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Sep 7, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 7, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-08T08:21:17.571+0000

  • Duration: 17 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 7, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 98.0% (49/50) 👍 12.444
Lines 92.005% (2152/2339) 👎 -0.591
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review September 7, 2023 10:19
@efd6 efd6 requested a review from a team as a code owner September 7, 2023 10:19
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
tenable_io: update dashboards, fix timestamp and improve fingerprinting
97bd007 
* update dashboard branding for the branding change
* make timestamp reflect last seen rather than first seen
* reduce event collision by adding fingerprint processor
@efd6 efd6 changed the title tenable_io: update dashboards update dashboards, fix timestamp and improve fingerprinting Sep 7, 2023
@efd6 efd6 requested a review from bhapas September 8, 2023 07:09
bhapas
bhapas approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit b3d9dc9 into elastic:main Sep 8, 2023
4 checks passed
@elasticmachine
Copy link

Package tenable_io - 2.0.1 containing this change is available at https://epr.elastic.co/search?package=tenable_io

2 similar comments
@elasticmachine
Copy link

Package tenable_io - 2.0.1 containing this change is available at https://epr.elastic.co/search?package=tenable_io

@elasticmachine
Copy link

Package tenable_io - 2.0.1 containing this change is available at https://epr.elastic.co/search?package=tenable_io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@efd6 efd6

Labels
bug Something isn't working Integration:Tenable.io
Projects
None yet
Milestone
No milestone
3 participants
@efd6 @elasticmachine @bhapas