Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ti_util] Change dashboard queries from match_phrase to wildcard #7731

Merged
merged 2 commits into from
Sep 18, 2023
Merged

[ti_util] Change dashboard queries from match_phrase to wildcard #7731

merged 2 commits into from
Sep 18, 2023

Conversation

chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Sep 8, 2023 •
edited
Loading

The ti_util generic threat intelligence dashboard wasn't picking up my data.

It was looking for a wildcard value (ti_*) using a match_phrase query type.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@chrisberkhout chrisberkhout requested a review from a team as a code owner September 8, 2023 17:49
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Sep 8, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-08T17:51:26.370+0000

  • Duration: 13 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@chrisberkhout chrisberkhout changed the title Change dashboard queries from match_phrase to wildcard [ti_util] Change dashboard queries from match_phrase to wildcard Sep 14, 2023
ShourieG
ShourieG approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kcreddy
kcreddy approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@chrisberkhout chrisberkhout merged commit ea2cbfb into elastic:main Sep 18, 2023
4 checks passed
@chrisberkhout chrisberkhout deleted the ti-util-query branch September 18, 2023 09:55
@elasticmachine
Copy link

Package ti_util - 1.2.3 containing this change is available at https://epr.elastic.co/search?package=ti_util

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

@ShourieG ShourieG ShourieG approved these changes

Assignees
No one assigned
Labels
bugfix Integration:Threat Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrisberkhout @elasticmachine @kcreddy @ShourieG