New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Barracuda_WAF] Change the package name #7735
Conversation
/test |
Hey @efd6 - I've added CODEOWNER entry. Would you mind running the tests again? 😄 |
Most of the changes are done for this PR. However, I'll waiting for @jamiehynds' input on the issue. Once done, I'll mark it to "Ready to review". |
/test |
🌐 Coverage report
|
Thanks @vinit-chauhan - looking at the package version, the manifest.yml mentions 0.1.0 but the UI is showing 1.5.0. Any ideas as to why there's a discrepancy? |
Hey @jamiehynds - looks like the one you are referring to is the old integration. I've attached the screenshot along with the PR, which has updated Title and Readme. I'll have to update the integration version and titles of Visualizations if required to be aligned with the new name. |
Hey @jamiehynds - Updated the PR to match the version per your suggestion on the issue. And marking the PR ready for review. 😄 |
Thanks @vinit-chauhan - I don't think you attached the screenshot, would you mind attaching? I'm looking at the latest version of the integration, which is appearing as 1.5.0. @bhapas worked on the WAF integration. Can you remember if you just replaced the existing datastream within the Barracuda integration? |
Hey @jamiehynds - Here's the Screenshot. In the older integration of If you want I can remove the older integrations and add this one or we can add an update to the old integration with a message that "we are moving to a new integration, and users would have to switch to the new integration." and later deprecate/remove it. If we want users to allow seamless updates, We will have to keep the package name the same. which is "barracuda". If we update the package name, to So there are two possible approaches to tackle this, Approach 1: Rename the integration package to Approach 2: Use the existing package name, It would allow the users to update the package with ease. However, on the other hand, it would break the conversion in the code base and field mappings ( Note: In this PR, I've used Approach 1. Let me know your thoughts, and the changes necessary. |
/test |
Looks like there is a confusion here? I think issue #7724 meant to change the integrations/packages/barracuda/manifest.yml Lines 3 to 5 in 720540a
|
Thanks @bhapas - correct, just wanted to adjust the title to ensure it's clear the integration only covers WAF events. The title was originally 'Barracuda Logs' due to multiple datastreams for different products within that integration, it's now just limited to WAF so hoping to adjust the title accordingly. |
Thanks @jamiehynds .. @vinit-chauhan , So this is just down to integrations/packages/barracuda/manifest.yml
- title: "Barracuda Logs"
- description: Ingest Events from Barracuda Web Application Firewall
+ title: "Barracuda Web Application Firewall"
+ description: Collect logs from Barracuda Web Application Firewall with Elastic Agent.
|
Ah, I see. I thought we were going to update the whole package. So it's just the Manifest file then. Thanks for the update, I'll do the changes later today. 😄 |
/test |
Package barracuda - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=barracuda |
What does this PR do?
As mentioned in issue, #7724 the package name of
Barracuda
needed to be changed. This PR, therefore changes the name of the package and all of its associated assets (package name, data_stream name, dashboard IDs, field names, etc. )Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots