New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NATS] Add route data stream metric types #7743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌐 Coverage report
|
Rollover test{
"acknowledged": true,
"shards_acknowledged": true,
"old_index": ".ds-metrics-nats.route-default-2023.09.21-000001",
"new_index": ".ds-metrics-nats.route-default-2023.09.21-000002",
"rolled_over": true,
"dry_run": false,
"conditions": {}
} Mappings"nats": {
"properties": {
"route": {
"properties": {
"in": {
"properties": {
"bytes": {
"type": "long",
"time_series_metric": "counter"
},
"messages": {
"type": "long",
"time_series_metric": "counter"
}
}
},
"ip": {
"type": "ip",
"time_series_dimension": true
},
"out": {
"properties": {
"bytes": {
"type": "long",
"time_series_metric": "counter"
},
"messages": {
"type": "long",
"time_series_metric": "counter"
}
}
},
"pending_size": {
"type": "long",
"time_series_metric": "gauge"
},
"port": {
"type": "long",
"time_series_dimension": true
},
"remote_id": {
"type": "keyword",
"time_series_dimension": true
},
"subscriptions": {
"type": "long",
"time_series_metric": "gauge"
}
}
}, |
agithomas
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from TSDB perspective
agithomas
reviewed
Oct 10, 2023
packages/nats/changelog.yml
Outdated
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "1.3.6" | |||
changes: | |||
- description: Added metric_type mapping to route data stream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- description: Added metric_type mapping to route data stream. | |
- description: Add metric_type mapping to route data stream. |
constanca-m
approved these changes
Oct 12, 2023
Package nats - 1.3.9 containing this change is available at https://epr.elastic.co/search?package=nats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
route
data stream metric types.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots