Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mimecast] Add new data_stream archive_search_logs #7750

Merged
merged 5 commits into from
Sep 13, 2023
Merged

[mimecast] Add new data_stream archive_search_logs #7750

merged 5 commits into from
Sep 13, 2023

Conversation

bhapas
Copy link
Contributor

@bhapas bhapas commented Sep 11, 2023 •
edited
Loading

What does this PR do?

Add new data_stream for Archive Search Logs

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

image

@bhapas bhapas force-pushed the mimecast-new-datastream branch 2 times, most recently from 279ce67 to fcf2c21 Compare September 11, 2023 08:11
@bhapas bhapas changed the title Add new data_stream archive_search_logs [mimecast] Add new data_stream archive_search_logs Sep 11, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 11, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-13T06:28:09.627+0000

  • Duration: 20 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 61
Skipped 0
Total 61

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 11, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (9/9) 💚
Files 100.0% (9/9) 💚 2.695
Classes 100.0% (9/9) 💚 2.695
Methods 94.853% (129/136) 👍 2.59
Lines 89.536% (1369/1529) 👍 1.206
Conditionals 100.0% (0/0) 💚

@bhapas bhapas marked this pull request as ready for review September 11, 2023 09:10
@bhapas bhapas requested a review from a team as a code owner September 11, 2023 09:10
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 reviewed Sep 11, 2023
View reviewed changes
packages/mimecast/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/mimecast/data_stream/archive_search_logs/agent/stream/httpjson.yml.hbs Outdated Show resolved Hide resolved
packages/mimecast/data_stream/archive_search_logs/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/mimecast/data_stream/archive_search_logs/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/mimecast/data_stream/archive_search_logs/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/mimecast/data_stream/archive_search_logs/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/mimecast/data_stream/archive_search_logs/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/mimecast/data_stream/archive_search_logs/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/mimecast/data_stream/archive_search_logs/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/mimecast/data_stream/archive_search_logs/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
@bhapas bhapas requested a review from efd6 September 12, 2023 06:07
kcreddy
kcreddy approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
You can merge once @efd6 gives approval. Thanks!

efd6
efd6 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but LGTM.

packages/mimecast/_dev/build/docs/README.md Outdated Show resolved Hide resolved
bhapas and others added 2 commits September 13, 2023 06:05
@bhapas @efd6
Fix pr comment
b8f8a22 
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@bhapas
Rebuild docs
b651a72
@bhapas bhapas merged commit ce8f1d1 into elastic:main Sep 13, 2023
4 checks passed
@elasticmachine
Copy link

Package mimecast - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=mimecast

@bhapas bhapas deleted the mimecast-new-datastream branch September 13, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@kcreddy kcreddy kcreddy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:mimecast Mimecast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mimecast] Add support for Archive Search Logs
4 participants
@bhapas @elasticmachine @kcreddy @efd6