Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Traefik] Add dimension fields for health datastream #7767

Merged

Conversation

harnish-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

This PR adds dimension fields for health data stream to support TSDB enablement.

Checklist

Screenshot

Refer: #7766

@harnish-elastic harnish-elastic marked this pull request as ready for review September 12, 2023 05:35
@harnish-elastic harnish-elastic requested a review from a team as a code owner September 12, 2023 05:35
@harnish-elastic harnish-elastic mentioned this pull request Sep 12, 2023
6 tasks
@agithomas
Copy link
Contributor

If there are multiple "status_codes", will there be separate documents or just one document ?

@elasticmachine
Copy link

elasticmachine commented Sep 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-29T06:08:02.690+0000

  • Duration: 20 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 12, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 3.475
Classes 100.0% (3/3) 💚 3.475
Methods 100.0% (26/26) 💚 7.917
Lines 97.706% (213/218) 👍 9.451
Conditionals 100.0% (0/0) 💚

@harnish-elastic
Copy link
Contributor Author

If there are multiple "status_codes", will there be separate documents or just one document ?

@agithomas Please refer to this response, the response will ingest to elasticsearch in one document because the field type is the object.

Co-authored-by: Richa Talwar <102972658+ritalwar@users.noreply.github.com>
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…into traefik-health-add-dimension

Conflicts:
	packages/traefik/changelog.yml
	packages/traefik/manifest.yml
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic harnish-elastic merged commit 8b54515 into elastic:main Oct 10, 2023
4 checks passed
@elasticmachine
Copy link

Package traefik - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=traefik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants