Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Traefik] Add metric_type for health datastream #7768

Merged
merged 8 commits into from
Oct 10, 2023
Merged

[O11y][Traefik] Add metric_type for health datastream #7768

merged 8 commits into from
Oct 10, 2023

Conversation

harnish-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

This PR adds metric_type mapping for the fields of the health data stream.

Checklist

Screenshot

Refer: #7766

@harnish-elastic harnish-elastic self-assigned this Sep 12, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review September 12, 2023 05:46
@harnish-elastic harnish-elastic requested a review from a team as a code owner September 12, 2023 05:46
@harnish-elastic harnish-elastic mentioned this pull request Sep 12, 2023
Closed
6 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 12, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-10T10:53:06.567+0000

  • Duration: 19 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 12, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (26/26) 💚
Lines 97.706% (213/218) 👍 2.184
Conditionals 100.0% (0/0) 💚

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
cca842c 
…into traefik-health-add-metric_type

Conflicts:
	packages/traefik/changelog.yml
	packages/traefik/manifest.yml
@harnish-elastic
Copy link
Contributor Author

/test

1 similar comment
@harnish-elastic
Copy link
Contributor Author

/test

@agithomas
Copy link
Contributor

@harnish-elastic , please complete the peer review.

@agithomas
Copy link
Contributor

@ritalwar , are you good to approve the PR ?

milan-elastic
milan-elastic approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar
Copy link
Contributor

ritalwar commented Oct 6, 2023

In the screenshot of Discover view, I notice gauge and counter icons associated with other fields, but for "response.status_codes," the icon doesn't match the specified type, which is "counter." Is the metric type successfully applied in this case?

@harnish-elastic
Copy link
Contributor Author

In the screenshot of Discover view, I notice gauge and counter icons associated with other fields, but for "response.status_codes," the icon doesn't match the specified type, which is "counter." Is the metric type successfully applied in this case?

Updated screenshot, thanks!

ritalwar
ritalwar approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

agithomas
agithomas approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
616baba 
…into traefik-health-add-metric_type

Conflicts:
	packages/traefik/changelog.yml
	packages/traefik/docs/README.md
	packages/traefik/manifest.yml
@harnish-elastic harnish-elastic merged commit 913c482 into elastic:main Oct 10, 2023
4 checks passed
@elasticmachine
Copy link

Package traefik - 1.9.1 containing this change is available at https://epr.elastic.co/search?package=traefik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritalwar ritalwar ritalwar approved these changes

@agithomas agithomas agithomas approved these changes

@milan-elastic milan-elastic milan-elastic approved these changes

Assignees

@harnish-elastic harnish-elastic

Labels
Integration:Traefik
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@harnish-elastic @elasticmachine @agithomas @ritalwar @milan-elastic