Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_meraki] Add event.action and message to specific events #7791

Merged
merged 8 commits into from
Sep 24, 2023

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Sep 13, 2023

What does this PR do?

Add event.action to: cisco_meraki.event_subtype: multiple_dhcp_servers_detected

Keep important information in message field for cisco_meraki.event_subtype:

  • dhcp
  • client_vpn_connect
  • blocked
  • port

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@LaZyDK LaZyDK changed the title [cisco_meraki] Add event.action and message to specific events #7790 [cisco_meraki] Add event.action and message to specific events Sep 13, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-22T15:16:48.186+0000

  • Duration: 18 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@LaZyDK LaZyDK marked this pull request as ready for review September 20, 2023 09:18
@LaZyDK LaZyDK requested a review from a team as a code owner September 20, 2023 09:18
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor

efd6 commented Sep 20, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Sep 21, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚 29.412
Classes 100.0% (9/9) 💚 29.412
Methods 100.0% (66/66) 💚 43.182
Lines 98.161% (1174/1196) 👍 58.2
Conditionals 100.0% (0/0) 💚

@LaZyDK
Copy link
Contributor Author

LaZyDK commented Sep 21, 2023

Ready for another test

@LaZyDK
Copy link
Contributor Author

LaZyDK commented Sep 22, 2023

Fixed conflicts. Ready again.

@efd6
Copy link
Contributor

efd6 commented Sep 22, 2023

/test

1 similar comment
@andrewkroh
Copy link
Member

/test

@efd6 efd6 merged commit d53d552 into elastic:main Sep 24, 2023
4 checks passed
@elasticmachine
Copy link

Package cisco_meraki - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki

@LaZyDK LaZyDK deleted the meraki_align_fields branch September 26, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cisco_meraki] Add event.action and message to specific events
5 participants