Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Apache Spark] Add metric_type for application data stream #7795

Conversation

harnish-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

This PR adds metric_type mapping for the fields of the application data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

To verify the metric_type, please refer to the below mbeans type that is used for data collection

  - mbean: 'metrics:name=application.*.runtime_ms,type=gauges'
    attributes:
    - attr: Value
      field: application.runtime.ms
  - mbean: 'metrics:name=application.*.cores,type=gauges'
    attributes:
    - attr: Value
      field: application.cores

@harnish-elastic harnish-elastic marked this pull request as ready for review September 13, 2023 10:44
@harnish-elastic harnish-elastic requested a review from a team as a code owner September 13, 2023 10:44
@harnish-elastic harnish-elastic mentioned this pull request Sep 13, 2023
21 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-12T11:30:20.944+0000

  • Duration: 20 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 13, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (12/16)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@aliabbas-elastic aliabbas-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…into apache_spark-application-add-metric_type

Conflicts:
	packages/apache_spark/changelog.yml
	packages/apache_spark/docs/README.md
	packages/apache_spark/manifest.yml
@harnish-elastic harnish-elastic merged commit 3e6d75e into elastic:main Oct 12, 2023
4 checks passed
@elasticmachine
Copy link

Package apache_spark - 0.7.1 containing this change is available at https://epr.elastic.co/search?package=apache_spark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants