Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitdefender,forcepoint_web,jumpcloud,tines] Remove version from ingest pipeline definitions #7807

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Sep 13, 2023

The ingest node pipelines contained a version attribute that is not useful in Fleet pipelines. This will not be allowed in future versions of package-spec.

Relates: elastic/package-spec#529

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh force-pushed the bitdefender/bugfix/remove-ingest-pipeline-version branch from 5ca0707 to a17ed17 Compare September 13, 2023 21:56
@elasticmachine
Copy link

elasticmachine commented Sep 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-14T04:11:14.982+0000

  • Duration: 18 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 43
Skipped 0
Total 43

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

…eline definitions

The ingest node pipelines contained a version attribute that
is not useful in Fleet pipelines. This will not be allowed in future
versions of package-spec.

Relates: elastic/package-spec#529
@andrewkroh andrewkroh force-pushed the bitdefender/bugfix/remove-ingest-pipeline-version branch from a17ed17 to 759ab32 Compare September 13, 2023 21:59
@andrewkroh andrewkroh changed the title [bitdefender,forcepoint_web] Remove version from ingest pipeline definitions [bitdefender,forcepoint_web,jumpcloud] Remove version from ingest pipeline definitions Sep 13, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 13, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 100.0% (7/7) 💚
Classes 100.0% (7/7) 💚
Methods 92.222% (83/90) 👎 -0.237
Lines 85.864% (1476/1719) 👎 -5.659
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tines package is mentioned in the linked issue, and still has the version attribute. Is there a reason it is not included in this set of changes?

@andrewkroh andrewkroh changed the title [bitdefender,forcepoint_web,jumpcloud] Remove version from ingest pipeline definitions [bitdefender,forcepoint_web,jumpcloud,tines] Remove version from ingest pipeline definitions Sep 14, 2023
@andrewkroh andrewkroh added the Integration:Tines No-code automation for security teams label Sep 14, 2023
@andrewkroh andrewkroh merged commit 1a8a4b2 into elastic:main Sep 14, 2023
4 checks passed
@elasticmachine
Copy link

Package bitdefender - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=bitdefender

@elasticmachine
Copy link

Package forcepoint_web - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=forcepoint_web

@elasticmachine
Copy link

Package jumpcloud - 1.2.2 containing this change is available at https://epr.elastic.co/search?package=jumpcloud

@elasticmachine
Copy link

Package tines - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=tines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:Bitdefender Bitdefender Integration:Forcepoint Web Security Forcepoint Web Security Integration:JumpCloud JumpCloud Integration:Tines No-code automation for security teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants