Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][CouchDB] Remove forwarded tag from metrics data streams #7826

Merged

Conversation

harnish-elastic
Copy link
Contributor

  • Bug

What does this PR do?

  • This PR remove forwarded tag from the metricbeat-based data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@harnish-elastic harnish-elastic self-assigned this Sep 14, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review September 14, 2023 13:05
@harnish-elastic harnish-elastic requested a review from a team as a code owner September 14, 2023 13:05
@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-21T08:36:10.335+0000

  • Duration: 16 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (7/7) 💚 4.938
Lines 94.175% (194/206) 👍 14.329
Conditionals 100.0% (0/0) 💚

@aliabbas-elastic
Copy link
Contributor

/test

Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@harnish-elastic harnish-elastic merged commit 647768b into elastic:main Oct 9, 2023
4 checks passed
@elasticmachine
Copy link

Package couchdb - 1.0.1 containing this change is available at https://epr.elastic.co/search?package=couchdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants