Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Websphere Application Server] Remove forwarded tag from metrics data streams #7829

Merged
merged 3 commits into from
Oct 9, 2023
Merged

[O11y][Websphere Application Server] Remove forwarded tag from metrics data streams #7829

merged 3 commits into from
Oct 9, 2023

Conversation

harnish-elastic
Copy link
Contributor

  • Bug

What does this PR do?

  • This PR remove forwarded tag from the metricbeat-based data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@harnish-elastic harnish-elastic self-assigned this Sep 14, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review September 14, 2023 13:40
@harnish-elastic harnish-elastic requested a review from a team as a code owner September 14, 2023 13:40
@harnish-elastic harnish-elastic mentioned this pull request Sep 14, 2023
Closed
7 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-09T08:23:14.571+0000

  • Duration: 28 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (28/28) 💚
Lines 100.0% (488/488) 💚 5.185
Conditionals 100.0% (0/0) 💚

@aliabbas-elastic
Copy link
Contributor

/test

1 similar comment
@harnish-elastic
Copy link
Contributor Author

/test

milan-elastic
milan-elastic approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ishleenk17
Copy link
Contributor

The build is failing, please check

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
5c17154 
…into websphere_application_server-remove-forwarded-tag

Conflicts:
	packages/websphere_application_server/changelog.yml
	packages/websphere_application_server/manifest.yml
ishleenk17
ishleenk17 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@harnish-elastic harnish-elastic merged commit 53d0d09 into elastic:main Oct 9, 2023
4 checks passed
@elasticmachine
Copy link

Package websphere_application_server - 1.0.1 containing this change is available at https://epr.elastic.co/search?package=websphere_application_server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@milan-elastic milan-elastic milan-elastic approved these changes

Assignees

@harnish-elastic harnish-elastic

Labels
bugfix Integration:WebsphereApplicationServer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@harnish-elastic @elasticmachine @aliabbas-elastic @ishleenk17 @milan-elastic