Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ti_anomali] Add DLM policy and Update format_version to 3.0.0 #7849

Merged
merged 4 commits into from Sep 25, 2023

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Sep 18, 2023

What does this PR do?

  • Adds DLM policy as it is required for Elastic Serverless offering.
  • Update format_version to 3.0.0
  • Add owner.type: elastic to package manifest.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR

  1. Follow these steps laid out in the doc to bring up Serverless project UP. An agent is installed locally which is connected to your Serverless project.
  2. Install package using zip file:
    elastic-package install --zip build/packages/ti_anomali-1.17.0.zip -v
  3. Add Anomali Integration policy.
  4. Start the Anomali integrator locally or on a cloud instance to start consuming the indicators.
  5. Go to Dev Tools within Serverless project and run:
    GET _data_stream/logs-ti_anomali.threatstream-default

which contains the DLM details:

      "lifecycle": {
        "enabled": true,
        "data_retention": "5d"
      },

Related issues

Screenshots

@kcreddy kcreddy added enhancement New feature or request Integration:Anomali labels Sep 18, 2023
@kcreddy kcreddy self-assigned this Sep 18, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-21T10:45:41.908+0000

  • Duration: 17 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 18, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (13/13) 💚 4.938
Lines 91.071% (357/392) 👍 11.226
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy changed the title [ti_anomali] Add DLM policy [ti_anomali] Add DLM policy and Update format_version to 3.0.0 Sep 18, 2023
@kcreddy kcreddy marked this pull request as ready for review September 21, 2023 07:38
@kcreddy kcreddy requested a review from a team as a code owner September 21, 2023 07:38
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcreddy kcreddy merged commit 916db46 into elastic:main Sep 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants