Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Golang] Fix description in README.md #7850

Merged
merged 7 commits into from
Sep 25, 2023
Merged

[O11y][Golang] Fix description in README.md #7850

merged 7 commits into from
Sep 25, 2023

Conversation

harnish-elastic
Copy link
Contributor

  • Bug

What does this PR do?

  • Fix descriptions in README.md

Related issues

@harnish-elastic harnish-elastic self-assigned this Sep 18, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review September 18, 2023 16:11
@harnish-elastic harnish-elastic requested a review from a team as a code owner September 18, 2023 16:11
@elasticmachine
Copy link

elasticmachine commented Sep 18, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-25T05:36:13.311+0000

  • Duration: 15 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 18, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (16/16) 💚
Lines 95.876% (186/194) 👍 10.406
Conditionals 100.0% (0/0) 💚

@harnish-elastic harnish-elastic mentioned this pull request Sep 20, 2023
Closed
@shmsr shmsr changed the title [O11y][Golang] Fix descriptions in README.md [O11y][Golang] Fix description in README.md Sep 21, 2023
shmsr
shmsr requested changes Sep 21, 2023
View reviewed changes
packages/golang/docs/README.md Outdated Show resolved Hide resolved
shmsr
shmsr requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

packages/golang/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/golang/changelog.yml Outdated Show resolved Hide resolved
harnish-elastic and others added 2 commits September 21, 2023 15:30
@harnish-elastic @shmsr
Update packages/golang/changelog.yml
2ebb662 
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@harnish-elastic
minor nit
e7ad8c6
shmsr
shmsr reviewed Sep 21, 2023
View reviewed changes
packages/golang/manifest.yml Outdated Show resolved Hide resolved
@shmsr
Copy link
Member

shmsr commented Sep 21, 2023

I did a small change i.e., Golang to Go (Golang) in 9c4c32b. Now, the changes LGTM.

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
63b0e11 
…into golang-update-readme

Conflicts:
	packages/golang/changelog.yml
	packages/golang/manifest.yml
@harnish-elastic harnish-elastic merged commit 26b822d into elastic:main Sep 25, 2023
4 checks passed
@elasticmachine
Copy link

Package golang - 0.4.4 containing this change is available at https://epr.elastic.co/search?package=golang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmsr shmsr shmsr approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees

@harnish-elastic harnish-elastic

Labels
Integration:Golang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harnish-elastic @elasticmachine @shmsr @muthu-mps