Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] Change include_linked_accounts default to true #7856

Merged
merged 2 commits into from Sep 25, 2023

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Sep 18, 2023

What does this PR do?

This PR is to change include_linked_accounts default to true to match metricbeat: elastic/beats#35686

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner September 18, 2023 17:16
@kaiyan-sheng kaiyan-sheng self-assigned this Sep 18, 2023
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner September 18, 2023 17:17
@elasticmachine
Copy link

elasticmachine commented Sep 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-18T17:16:34.969+0000

  • Duration: 53 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 209
Skipped 3
Total 212

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -2.142
Classes 94.444% (17/18) 👎 -2.142
Methods 85.953% (257/299) 👎 -6.317
Lines 86.024% (7509/8729) 👎 -2.284
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng merged commit 922e3a8 into elastic:main Sep 25, 2023
4 checks passed
@kaiyan-sheng kaiyan-sheng deleted the enable_cross_account branch September 25, 2023 15:32
@elasticmachine
Copy link

Package aws - 2.3.0 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants