Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elastic_agent] Fix inconsistencies in field mapping types #7872

Merged

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Sep 19, 2023

What does this PR do?

Fix mapping and description for the system.process.cpu.{system,user,total}.time.ms fields. The fields should be of type long instead of date.

Align mapping for the beat.stats.libbeat.config.{running,starts,stops} fields with the beat integration. The beat integration uses long so align to that.

For the message field, consistently use the ECS defined mapping type of match_only_text.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

…pping

Fix mapping and description for the `system.process.cpu.{system,user,total}.time.ms` fields.

Fixes elastic#4245
…s} to long

Align mapping for the `beat.stats.libbeat.config.{running,starts,stops}` fields with the `beat` integration.

Fixes elastic#4245
@andrewkroh andrewkroh added bug Something isn't working Team:Elastic-Agent Label for the Agent team Integration:Elastic-Agent labels Sep 19, 2023
@andrewkroh andrewkroh requested a review from a team as a code owner September 19, 2023 14:46
@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@andrewkroh andrewkroh force-pushed the elastic_agent/bugfix/mapping-conflicts branch from 11be657 to 4e6f2dc Compare September 19, 2023 14:46
@elasticmachine
Copy link

elasticmachine commented Sep 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-19T14:47:41.159+0000

  • Duration: 17 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.689
Classes 100.0% (0/0) 💚 3.689
Methods 33.333% (25/75) 👎 -58.677
Lines 100.0% (0/0) 💚 12.022
Conditionals 100.0% (0/0) 💚

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewkroh andrewkroh merged commit 16016c9 into elastic:main Sep 20, 2023
4 checks passed
@elasticmachine
Copy link

Package elastic_agent - 1.13.1 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

2 similar comments
@elasticmachine
Copy link

Package elastic_agent - 1.13.1 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

@elasticmachine
Copy link

Package elastic_agent - 1.13.1 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:Elastic-Agent Team:Elastic-Agent Label for the Agent team
Projects
None yet
3 participants