[symantec_endpoint] Adopt ECS log.syslog mappings #7878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
ECS added log.syslog fields and those needed to be adopted by symantec_endpoint to avoid type conflicts across integrations and to make the syslog data representation consist. As much as possible this tries to avoid breaking changes, but the field data type of log.syslog.version had to change from long to keyword to be consistent with ECS. The other existing symantec_endpoint log.syslog fields that are not part of ECS were maintained and documented as deprecated. log.syslog.process.name is an alias to ECS log.syslog.appname. And log.syslog.process.name is kept as a long representation of ECS log.syslog.procid. Fixes elastic#7843
andrewkroh
force-pushed
the
symantec_endpoint/feature/adopt-ecs-log-syslog
branch
from
9b87c74
to
d4f0e7c
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
efd6
approved these changes
Sep 20, 2023
|
Package symantec_endpoint - 2.11.0 containing this change is available at https://epr.elastic.co/search?package=symantec_endpoint |
1 similar comment
|
Package symantec_endpoint - 2.11.0 containing this change is available at https://epr.elastic.co/search?package=symantec_endpoint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ECS added log.syslog fields and those needed to be adopted by symantec_endpoint to avoid type conflicts across integrations and to make the syslog data representation consist.
As much as possible this tries to avoid breaking changes, but the field data type of log.syslog.version had to change from long to keyword to be consistent with ECS.
The other existing symantec_endpoint log.syslog fields that are not part of ECS were maintained and documented as deprecated. log.syslog.process.name is an alias to ECS log.syslog.appname. And log.syslog.process.name is kept as a long representation of ECS log.syslog.procid.
Fixes #7843
Checklist
changelog.ymlfile.Related issues