Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] perfmon add refresh_wildcard_counters variable #7897

Merged

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Add the refresh_wildcard_counters variable to the windows perfmon data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

  1. elastic-package build
  2. elastic-package stack up -d
  3. login to Kibana
  4. create empty policy
  5. make add windows integration
  6. Enable refresh_wildcard_counters variable
  7. Save policy
  8. Inspect policy, make sure variable exists and is true

Related issues

@leehinman leehinman added the enhancement New feature or request label Sep 20, 2023
@leehinman leehinman marked this pull request as ready for review September 20, 2023 18:36
@leehinman leehinman requested review from a team as code owners September 20, 2023 18:36
@elasticmachine
Copy link

elasticmachine commented Sep 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-20T18:36:25.277+0000

  • Duration: 20 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 150
Skipped 0
Total 150

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 91.667% (11/12) 👎 -8.333
Classes 91.667% (11/12) 👎 -8.333
Methods 85.156% (109/128) 👎 -12.844
Lines 91.55% (5840/6379) 👎 -0.455
Conditionals 100.0% (0/0) 💚

@leehinman leehinman merged commit bd595c1 into elastic:main Sep 20, 2023
4 checks passed
@elasticmachine
Copy link

Package windows - 1.37.0 containing this change is available at https://epr.elastic.co/search?package=windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[windows perfmon] Include perfmon.refresh_wildcard_counters variable
4 participants