Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Docker] Migrate Docker Overview dashboard to lens #7942

Merged
merged 5 commits into from Sep 29, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Sep 22, 2023

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Docker visualizations to the lens in the current Kibana version 8.8.0 itself.

Migration stats

  Before Migration   After Migration  
  Lens Vizualization Lens Vizualization
[Metrics Docker] Overview 0 7

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

Notes

@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-27T12:56:54.546+0000

  • Duration: 19 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 96.667% (29/30) 👍 3.529
Lines 100.0% (0/0) 💚 5.214
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review September 25, 2023 05:14
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner September 25, 2023 05:14
@rajvi-patel-22
Copy link
Contributor Author

/test

}
}
},
"title": "Docker containers [Metrics Docker] (converted)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Docker containers [Metrics Docker] (converted)",
"title": "Docker containers [Metrics Docker]",

"shape": "donut"
}
},
"title": "Docker containers per host [Metrics Docker] (converted)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Docker containers per host [Metrics Docker] (converted)",
"title": "Docker containers per host [Metrics Docker]",

"y": 0
},
"panelIndex": "6cb38196-b994-40f8-b871-09d8e532a843",
"title": "Number of Running Containers [Metrics Docker]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Number of Running Containers [Metrics Docker]",
"title": "Running Containers [Metrics Docker]",

"y": 0
},
"panelIndex": "e5f670cb-36d3-4481-be82-733775edcb83",
"title": "Number of Paused Containers [Metrics Docker]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Number of Paused Containers [Metrics Docker]",
"title": "Paused Containers [Metrics Docker]",

"y": 0
},
"panelIndex": "58e96448-b689-45bd-b0b2-a0ee57fc0235",
"title": "Number of Stopped Containers [Metrics Docker]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Number of Stopped Containers [Metrics Docker]",
"title": "Stopped Containers [Metrics Docker]",

"shape": "donut"
}
},
"title": "Docker images and names [Metrics Docker] (converted)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Docker images and names [Metrics Docker] (converted)",
"title": "Docker images and names [Metrics Docker] ",

"yTitle": "Count"
}
},
"title": "CPU usage [Metrics Docker] (converted)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "CPU usage [Metrics Docker] (converted)",
"title": "CPU usage [Metrics Docker]",

"yTitle": "Count"
}
},
"title": "Memory usage [Metrics Docker] (converted)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Memory usage [Metrics Docker] (converted)",
"title": "Memory usage [Metrics Docker]",

"yTitle": "Count"
}
},
"title": "Network IO [Metrics Docker] (converted)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Network IO [Metrics Docker] (converted)",
"title": "Network IO [Metrics Docker] ",

"panelIndex": "2",
"panelRefName": "panel_1",
"version": "7.3.0"
"title": "Docker containers [Metrics Docker]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need [Metrics Docker] to be visible to all titles? Shall we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gizas, According to Elastic documentation for integration development it is recommended to add suffix <NAME> [<Metrics | Logs> <PACKAGE NAME>]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is best to remove it, according to the dashboard guidelines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the issue for removing suffix from docker visualization.

Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit ecc3d77 into elastic:main Sep 29, 2023
4 checks passed
@elasticmachine
Copy link

Package docker - 2.8.3 containing this change is available at https://epr.elastic.co/search?package=docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][Docker] Docker Lens migration
5 participants