Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infoblox BloxOne DDI] Ingest Pipeline Errors on Empty IP Fields, and Blank Messages Ingested #7943

Merged
merged 9 commits into from Sep 25, 2023
Merged

[Infoblox BloxOne DDI] Ingest Pipeline Errors on Empty IP Fields, and Blank Messages Ingested #7943

merged 9 commits into from Sep 25, 2023

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Sep 22, 2023 •
edited

Type of change

  • Bug

What does this PR do?

This PR handles errors when attempting to convert empty fields '' to IP types, as well as drops empty messages.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have incremented the version in my package's mainfest.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@MakoWish MakoWish marked this pull request as ready for review September 22, 2023 16:43
@MakoWish MakoWish requested a review from a team as a code owner September 22, 2023 16:43
@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-25T21:04:47.288+0000

  • Duration: 15 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Sep 25, 2023

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (42/42) 💚
Lines 98.291% (2588/2633) 👍 6.382
Conditionals 100.0% (0/0) 💚

efd6
efd6 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit bea0a20 into elastic:main Sep 25, 2023
4 checks passed
@MakoWish MakoWish deleted the infoblox_bloxone_ddi_empty_ip_array_fix branch September 25, 2023 22:49
@elasticmachine
Copy link

Package infoblox_bloxone_ddi - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infoblox BloxOne DDI] Ingest Pipeline Errors on Empty IP Fields, and Blank Messages Ingested
3 participants
@MakoWish @elasticmachine @efd6