Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Google workspace pagination #795

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Fix Google workspace pagination #795

merged 1 commit into from
Mar 22, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Mar 22, 2021

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

mtojek
mtojek approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

Would be cool to add some pipeline tests to verify it.

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #795 updated

  • Start Time: 2021-03-22T11:37:05.970+0000

  • Duration: 20 min 29 sec

  • Commit: c53acc4

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

Trends 🧪

Image of Build Times

Image of Tests

@marc-gr marc-gr merged commit 90c162e into elastic:master Mar 22, 2021
@marc-gr marc-gr deleted the fix_gw_cursor_date branch March 22, 2021 12:12
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@marc-gr
Fix Google workspace pagination (elastic#795)
0cab0ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marc-gr @elasticmachine @mtojek