Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github] Fix docs for Audit log permissions #7954

Merged
merged 3 commits into from Sep 25, 2023

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Sep 25, 2023

What does this PR do?

Github token doesn't require admin:org scope in order to fetch the audit logs of an organization. This PR removes that scope from the token permissions.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

  • Fix docs

@kcreddy kcreddy added Integration:Github Github Integration docs labels Sep 25, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-25T07:06:24.055+0000

  • Duration: 16 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 100.0% (65/65) 💚
Lines 93.874% (996/1061) 👎 -2.003
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy marked this pull request as ready for review September 25, 2023 06:52
@kcreddy kcreddy requested a review from a team as a code owner September 25, 2023 06:52
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

packages/github/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/github/_dev/build/docs/README.md Show resolved Hide resolved
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcreddy kcreddy merged commit c77859e into elastic:main Sep 25, 2023
4 checks passed
@elasticmachine
Copy link

Package github - 1.23.1 containing this change is available at https://epr.elastic.co/search?package=github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Integration:Github Github Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants