Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Universal Profiling] Add inputs for collector/symbolizer #7962

Merged
merged 6 commits into from Sep 28, 2023
Merged

[Universal Profiling] Add inputs for collector/symbolizer #7962

merged 6 commits into from Sep 28, 2023

Conversation

inge4pres
Copy link
Contributor

@inge4pres inge4pres commented Sep 25, 2023 •
edited

What does this PR do?

Add configuration options for universal_profiling integrations (collector/symbolizer) to set logging, telemetry and memory limits for the running binaries.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • test the new options are propagated through Fleet

How to test this PR locally

  • Run a local stack with elastic-stack up (stack version 8.10 or higher)
  • Build an install the new packages in Kibana
  • Create an agent policy and enroll an agent locally
  • Configure the new vars
  • Validate they are actually used in the binaries

@inge4pres inge4pres added the enhancement New feature or request label Sep 25, 2023
@inge4pres inge4pres self-assigned this Sep 25, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-28T08:09:20.409+0000

  • Duration: 15 min 0 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@inge4pres
profiling: add inputs for collector/symbolizer
cdf91a7 
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
@inge4pres inge4pres changed the title profiling: add inputs for collector/symbolizer [Universal Profiling] Add inputs for collector/symbolizer Sep 26, 2023
@inge4pres inge4pres marked this pull request as ready for review September 26, 2023 15:27
@inge4pres inge4pres requested a review from a team as a code owner September 26, 2023 15:27
@inge4pres
Copy link
Contributor Author

@elastic/fleet there's a CI failure trying to fetch Kibana image

docker.elastic.co/kibana/kibana:8.10.0

is it expected?

@inge4pres inge4pres mentioned this pull request Sep 26, 2023
Merged
@rockdaboot
Copy link
Contributor

@elastic/fleet there's a CI failure trying to fetch Kibana image

docker.elastic.co/kibana/kibana:8.10.0

is it expected?

I can only pull 8.10.1 or 8.10.2.

@inge4pres
Copy link
Contributor Author

I can only pull 8.10.1 or 8.10.2.

Thanks for the hint, I think we then can solve it by increasing the constraint Kibana version to 8.10.2

inge4pres and others added 3 commits September 27, 2023 10:37
@inge4pres @florianl @rockdaboot
Suggestions from code review
ce21f29 
Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
Co-authored-by: Tim Rühsen <tim.ruehsen@gmx.de>
@inge4pres
increase Kibana version
2f03839
@inge4pres
increase Kibana version
5254490
@inge4pres @danielmitterdorfer
Suggestions from code review
aa949c7 
Co-authored-by: Daniel Mitterdorfer <danielmitterdorfer@users.noreply.github.com>
rockdaboot
rockdaboot reviewed Sep 27, 2023
View reviewed changes
packages/universal_profiling_collector/manifest.yml Outdated
type: text
default: ""
description: |
Set a soft memory limit for the program. The format for Megabytes is "MB", for Mebibytes is "MiB", etc...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the same description as in the symbolizer's manifest ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 2610a38

florianl
florianl approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@florianl florianl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine 👍 we can adjust descriptions later on as well.

@inge4pres
update descirption
2610a38 
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
@inge4pres inge4pres merged commit 720540a into main Sep 28, 2023
4 checks passed
@elasticmachine
Copy link

Package profiler_collector - 8.10.0 containing this change is available at https://epr.elastic.co/search?package=profiler_collector

@elasticmachine
Copy link

Package profiler_symbolizer - 8.10.0 containing this change is available at https://epr.elastic.co/search?package=profiler_symbolizer

inge4pres added a commit to elastic/kibana that referenced this pull request Oct 4, 2023
@inge4pres
fleet packages: upgrade profiling bundled integrations (#167307)
7e24f25 
## Summary

Upgrade the bundled Universal Profiling packages to run the backend
using the new version that will be published with
elastic/integrations#7962

Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer left review comments

@rockdaboot rockdaboot rockdaboot left review comments

@florianl florianl florianl approved these changes

Assignees

@inge4pres inge4pres

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@inge4pres @elasticmachine @rockdaboot @florianl @danielmitterdorfer