Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECS][crowdstrike] Correcting invalid ECS field usages at root-level #7968

Merged
merged 4 commits into from Sep 26, 2023

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Sep 25, 2023

What does this PR do?

Correcting invalid ECS os.* field usage at the root-level

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kgeller kgeller changed the title Correcting invalid ECS os field usages at root-level [ECS][crowdstrike] Correcting invalid ECS field usages at root-level Sep 25, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-26T13:26:05.208+0000

  • Duration: 16 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (15/15) 💚
Classes 100.0% (15/15) 💚
Methods 95.876% (93/97)
Lines 88.201% (3588/4068)
Conditionals 100.0% (0/0) 💚

@kgeller kgeller marked this pull request as ready for review September 25, 2023 19:51
@kgeller kgeller requested a review from a team as a code owner September 25, 2023 19:51
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgeller kgeller merged commit 9f4fd45 into elastic:main Sep 26, 2023
4 checks passed
@kgeller kgeller deleted the 7808-crowdstrike branch September 26, 2023 13:44
@elasticmachine
Copy link

Package crowdstrike - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=crowdstrike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:Crowdstrike
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants