Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oracle_weblogic] Use ECS definition for 'message' field type #7971

Merged
merged 1 commit into from
Sep 26, 2023
Merged

[oracle_weblogic] Use ECS definition for 'message' field type #7971

merged 1 commit into from
Sep 26, 2023

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Sep 25, 2023 •
edited
Loading

What does this PR do?

The admin_server, domain, and managed_server data streams had the message field mapped as a keyword. All other integrations use a text-family field type. The field is specified by ECS so this will now reference the ECS definition.

This causes a conflict in the logs-* data view.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@andrewkroh andrewkroh added Integration:oracle_weblogic Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Sep 25, 2023
@andrewkroh
oracle_weblogic - Use ECS definition for 'message' field type
47304cf 
The admin_server, domain, and managed_server data streams had the `message`
field mapped as a `keyword`. All other integrations use a text-family field type. The
field is specified by ECS so this will now reference the ECS definition.
@andrewkroh andrewkroh force-pushed the bugfix/oracle_weblogic/message-field-type branch from 20c0479 to 47304cf Compare September 25, 2023 21:54
@andrewkroh andrewkroh marked this pull request as ready for review September 25, 2023 21:55
@andrewkroh andrewkroh requested a review from a team as a code owner September 25, 2023 21:55
@andrewkroh andrewkroh added the bug Something isn't working label Sep 25, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-25T21:55:15.285+0000

  • Duration: 26 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 49
Skipped 0
Total 49

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (44/44) 💚
Lines 100.0% (239/239) 💚 8.091
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh changed the title oracle_weblogic - Use ECS definition for 'message' field type [oracle_weblogic] Use ECS definition for 'message' field type Sep 26, 2023
@ishleenk17
Copy link
Contributor

ishleenk17 commented Sep 26, 2023 •
edited
Loading

@andrewkroh Since it is a change in datatype due to ECS mapping, it could lead to an issue for existing customers.
We are following a practice to add the reindexing steps in the troubleshooting section of README, in case a customer faces an issue and there is a need to do one.
For eg: Citrix ADC

@andrewkroh
Copy link
Member Author

I think this readme already has the section you are talking about. Will that be sufficient?

integrations/packages/oracle_weblogic/_dev/build/docs/README.md

Lines 40 to 42 in 03b7596

To reindex the data, the following steps must be performed.
1. Stop the data stream by going to `Integrations -> Oracle WebLogic -> Integration policies` open the configuration of Oracle WebLogic and disable the `Collect Oracle WebLogic metrics` toggle to reindex metrics data stream and disable the `Collect Oracle WebLogic logs` toggle to reindex logs data stream and save the integration.

@ishleenk17
Copy link
Contributor

I think this readme already has the section you are talking about. Will that be sufficient?

integrations/packages/oracle_weblogic/_dev/build/docs/README.md

Lines 40 to 42 in 03b7596

To reindex the data, the following steps must be performed.
1. Stop the data stream by going to `Integrations -> Oracle WebLogic -> Integration policies` open the configuration of Oracle WebLogic and disable the `Collect Oracle WebLogic metrics` toggle to reindex metrics data stream and disable the `Collect Oracle WebLogic logs` toggle to reindex logs data stream and save the integration.

Should be good!

ishleenk17
ishleenk17 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewkroh andrewkroh merged commit b59f497 into elastic:main Sep 26, 2023
4 checks passed
@elasticmachine
Copy link

Package oracle_weblogic - 1.0.2 containing this change is available at https://epr.elastic.co/search?package=oracle_weblogic

@ishleenk17 ishleenk17 mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Integration:oracle_weblogic Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewkroh @elasticmachine @ishleenk17