Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle both clientIp and clientIP in azure app gateway #7995

Merged
merged 2 commits into from Sep 27, 2023
Merged

Conversation

dmathieu
Copy link
Member

What does this PR do?

There appears to be cases where Azure Application Gateway provides the client IP as json.properties.clientIP, and others where it provides it as json.properties.clientIp.

We currently only handle the former to rename the field into source.ip.

- rename:
field: json.properties.clientIP
target_field: source.address
ignore_missing: true

This change ensures a clientIp is first renamed to clientIP, so it can then become source.ip.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

This is unit tested.

Related issues

Screenshots

@dmathieu dmathieu added the bug Something isn't working label Sep 27, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-27T13:24:19.898+0000

  • Duration: 14 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 27, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👍 3.442
Lines 85.021% (2821/3318) 👎 -12.469
Conditionals 100.0% (0/0) 💚

@dmathieu dmathieu force-pushed the azure-clientIp branch 2 times, most recently from 3315897 to 3540111 Compare September 27, 2023 09:37
@dmathieu dmathieu marked this pull request as ready for review September 27, 2023 09:55
@dmathieu dmathieu requested a review from a team as a code owner September 27, 2023 09:55
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We only need to bump the version and add a changelog, and we're ready to go!

@dmathieu dmathieu merged commit 4396905 into main Sep 27, 2023
4 checks passed
@dmathieu dmathieu deleted the azure-clientIp branch September 27, 2023 13:38
@elasticmachine
Copy link

Package azure - 1.5.33 containing this change is available at https://epr.elastic.co/search?package=azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants