Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Prometheus] Migrate Prometheus Server Overview dashboard to lens #8016

Merged

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Sep 29, 2023

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Prometheus visualizations to the lens in the current Kibana version 8.9.0 itself.

Migration stats

  Before Migration   After Migration  
  Lens Vizualization Lens Vizualization
[Metrics Prometheus] Prometheus Server overview 0 12  12

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.9.0 itself.

Related issues

@elasticmachine
Copy link

elasticmachine commented Sep 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-04T09:37:40.850+0000

  • Duration: 15 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 29, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (8/12) 👍 41.667
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review September 29, 2023 05:30
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner September 29, 2023 05:30
"type": "visualization",
"version": "8.4.0"
"type": "lens",
"version": "8.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just from curiosity, is this extracted from 8.9.0 and why here we have 8.7.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gizas, Dashboards could not be exported from 8.9.0 due to below error. Therefore I have exported dashboard from 8.7.0 as minimum Kibana version for Prometheus is 8.9.0.
image

}
],
"timeRestore": false,
"title": "[Metrics Prometheus] Prometheus Server overview",
"version": 1
},
"coreMigrationVersion": "8.4.0",
"coreMigrationVersion": "8.7.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here this remained to 8.7.0. Is this expected?

@kush-elastic kush-elastic self-requested a review October 4, 2023 09:37
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit edc0b18 into elastic:main Oct 4, 2023
4 checks passed
@elasticmachine
Copy link

Package prometheus - 1.13.1 containing this change is available at https://epr.elastic.co/search?package=prometheus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][Prometheus] Prometheus Lens migration
4 participants