Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microsoft_sqlserver: Bump minimum kibana.version #8019

Merged
merged 2 commits into from Sep 29, 2023

Conversation

shmsr
Copy link
Member

@shmsr shmsr commented Sep 29, 2023

What does this PR do?

Bumps the minimum kibana.version in manifest.yml to make it mandatory to use ^8.10.2 stack for the new fetch_from_all_databases feature which was not enforced earlier.

Based on a conversation with @ishleenk17 and also referring to

> Note: The package version with such condition as above will be only available in Kibana version >=8.7.0
made a decision to bump the kibana.version.

Update: Upgrading the stack to ^8.10.2 as 8.10.0 and 8.10.1 have security flaws and it is recommended to use ^8.10.2

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@shmsr shmsr requested a review from a team as a code owner September 29, 2023 07:34
@shmsr shmsr self-assigned this Sep 29, 2023
@shmsr shmsr added Integration:microsoft_sqlserver Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Sep 29, 2023
@shmsr shmsr changed the title microsoft_sqlserver: Bump minimum kibana.version microsoft_sqlserver: Bump minimum kibana.version Sep 29, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-29T09:00:09.362+0000

  • Duration: 22 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.75% (30/32) 👎 -6.25
Lines 100.0% (1252/1252) 💚 5.877
Conditionals 100.0% (0/0) 💚

@shmsr shmsr merged commit 81401f3 into elastic:main Sep 29, 2023
4 checks passed
@elasticmachine
Copy link

Package microsoft_sqlserver - 2.2.2 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

@shmsr shmsr deleted the bump-mssql-kibana-version branch September 29, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:microsoft_sqlserver Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants