Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fortinet] Add support for 7.4 events #8036

Merged
merged 9 commits into from
Oct 30, 2023
Merged

[Fortinet] Add support for 7.4 events #8036

merged 9 commits into from
Oct 30, 2023

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 2, 2023 •
edited
Loading

Proposed commit message

Adds more test coverage for 6.2 events
Adds definitions for 7.4 event fields
Adds fixes for 7.4 events
Adds 7.4 events test coverage
Adds network_direction processor in addition to interface based direction resolution
Fix interface options for udp and tcp inputs

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@marc-gr marc-gr added enhancement New feature or request Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. labels Oct 2, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 2, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-30T08:32:47.295+0000

  • Duration: 18 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 2, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (40/40) 💚 66.667
Lines 92.686% (1318/1422) 👎 -7.314
Conditionals 100.0% (0/0) 💚

@ebeahan ebeahan mentioned this pull request Oct 13, 2023
Open
@marc-gr marc-gr marked this pull request as ready for review October 26, 2023 15:20
@marc-gr marc-gr requested a review from a team as a code owner October 26, 2023 15:20
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 reviewed Oct 26, 2023
View reviewed changes
packages/fortinet_fortigate/data_stream/log/agent/stream/log.yml.hbs Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/agent/stream/log.yml.hbs Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
@marc-gr marc-gr requested a review from efd6 October 27, 2023 09:07
efd6
efd6 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits only which probably should happen in another PR. LGTM

packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/traffic.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/traffic.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated Show resolved Hide resolved
packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated Show resolved Hide resolved
@marc-gr marc-gr merged commit e17b11b into elastic:main Oct 30, 2023
4 checks passed
@marc-gr marc-gr deleted the fortinet-7x-support branch October 30, 2023 09:08
@elasticmachine
Copy link

Package fortinet_fortigate - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

3 similar comments
@elasticmachine
Copy link

Package fortinet_fortigate - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

@elasticmachine
Copy link

Package fortinet_fortigate - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

@elasticmachine
Copy link

Package fortinet_fortigate - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

@andrewkroh andrewkroh added the Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs label Jul 22, 2024
@andrewkroh andrewkroh removed the Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs
Projects
None yet
Milestone
No milestone
4 participants
@marc-gr @elasticmachine @efd6 @andrewkroh