Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloud_security_posture] Allow multiple installations #8043

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

amirbenun
Copy link
Contributor

Allow multiple installations of the cloud_security_posutre package on the same agent policy.
This change is required for the agentless epic.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@amirbenun amirbenun added the enhancement New feature or request label Oct 2, 2023
@amirbenun amirbenun requested a review from a team as a code owner October 2, 2023 13:09
@elasticmachine
Copy link

elasticmachine commented Oct 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-03T11:09:05.414+0000

  • Duration: 15 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@eyalkraft eyalkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we make sure it doesn't happen in ESS? only on the agentless policy?

@amirbenun
Copy link
Contributor Author

amirbenun commented Oct 3, 2023

@eyalkraft We won't, once we allow it there is no reason to do that distinction.

@@ -5,8 +5,11 @@
# 1.4.x - 8.9.x
# 1.3.x - 8.8.x
# 1.2.x - 8.7.x
- version: "1.6.0-preview13"
- version: "1.6.0-preview14"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be pushed for this release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be a part of this release, no reason to hold it back.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -50.758
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@amirbenun amirbenun merged commit 4d984df into elastic:main Oct 3, 2023
4 checks passed
@amirbenun amirbenun deleted the csp-multiple-true branch October 3, 2023 12:07
@elasticmachine
Copy link

Package cloud_security_posture - 1.6.0-preview15 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.6.0-preview16 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants